jerboa icon indicating copy to clipboard operation
jerboa copied to clipboard

Tapping on comments that end in a link open the link.

Open TrollBlox opened this issue 2 years ago • 4 comments

** Jerboa Version ** 0.0.33-alpha

Describe the bug Tapping on comments that end in a link opens the link, even when not tapping the link directly.

To Reproduce Steps to reproduce the behavior:

  1. Find a comment that ends with a link.
  2. Tap on the comment (but not the link).
  3. Link opens.

The comment by @[email protected] on this post is where I found the bug.

TrollBlox avatar Jun 11 '23 04:06 TrollBlox

That comment seems to be gone, but I also can't reproduce this issue. For me, no matter where I tapped, it collapsed/expanded the comment, unless of course I tapped on the username or the link itself. Where are you tapping on the comment?

sensiblepuffin avatar Jun 12 '23 01:06 sensiblepuffin

I had a screen recording that I stupidly deleted. I was clicking directly horizontally of the link (but not on it).

TrollBlox avatar Jun 12 '23 01:06 TrollBlox

Ah, I see it now.

links.webm

sensiblepuffin avatar Jun 12 '23 03:06 sensiblepuffin

Yes. That is the issue I was experiencing.

TrollBlox avatar Jun 12 '23 03:06 TrollBlox

I don't think this is something that Jerboa can fix. It's a third party plugin that parses markdown links https://noties.io/Markwon/docs/v4/linkify/

ZJouba avatar Aug 03 '23 14:08 ZJouba

This more of a consequence that we use the default MovementMethod for Markwon. It is pretty flawed. If you click on a line after a clickablespan (links, images) it will still call that clickable span. We need to. implement a better one ourself. I already looked at that but I have not found the time yet to implement it yet. As I want to add longclick and shortclick. see #1096

MV-GH avatar Aug 08 '23 09:08 MV-GH