draft: Change CommunityTopBar to use LargeTopAppBar from ExperimentalMaterial3Api

[vijaykramesh]

Right now on the web UI (in mobile and desktop) a community icon optionally appears on the bottom left, while the banner is centered:

but meanwhile in jerboa the community icon is centered as well, which generally obscures the middle of the banner picture:

I would propose changing the jerboa UI to match web mobile & desktop, and have the community icon optionally appear bottom left justified with the community banner centered.

Creating this MR to propose the idea and then let me see if I can get this building locally to actually see if it works.

[dessalines]

Rather than doing little changes like this, we really need to move the entire banner, and about sections, into a top, smart collapsing app bar. For both the profile and community pages.

See #7

[vijaykramesh]

that makes sense to me, will continue to fool around with this to see what I can come up with.

have something "functionally" working and now need to move things around some -

[vijaykramesh]

Latest version:

[vijaykramesh]

and just for comparison, the current version -

[vijaykramesh]

ok this is basically ready for community (but not yet done for profile)

@dessalines some outstanding questions I had - should the community title appear even when there is a banner? right now I have it showing banner or title (and then optional icon overlay on the bottom left of the banner). and based on wholly unscientific looking around on lemmy I chose LargeTopAppBar to best accommodate larger banners.

also I'd prefer to not add profile in this same MR but then take a pass at adding it, but is that OK with you or do you want a single MR with both implemented so it closes issue #7 ?

added a few more previews to validate the subscribed status looks good, and also added CommunityTopSectionTest and modified the woodpecker yaml to run - ./gradlew connectedAndroidTest test - I'm not sure if this was wholly necessary, I didn't see these actually running anywhere as a part of the pipeline (and an erroneous print makes the tests currently fail on main, so I don't think they are)

[vijaykramesh]

commented out the test step for now it isn't working in CI and as I mentioned above I've never done android dev so am not sure of best practices here. Locally it works in android studio or via ./gradlew connectedAndroidTest test as long as I have android studio running... 🤷

[vijaykramesh]

rather than continually rebasing remote main onto this I'll wait for a review from @dessalines and answers to my questions above - then can do one last update to latest so CI will pass again.

[dessalines]

should the community title appear even when there is a banner? right now I have it showing banner or title (and then optional icon overlay on the bottom left of the banner). and based on wholly unscientific looking around on lemmy I chose LargeTopAppBar to best accommodate larger banners.

I see the standard in Boost for reddit is to have titles / extra info at the bottom:

Then, to collapse into a simple name and options bar (that also smart hides when scrolling):

also I'd prefer to not add profile in this same MR but then take a pass at adding it, but is that OK with you or do you want a single MR with both implemented so it closes issue https://github.com/dessalines/jerboa/issues/7 ?

We might as well add both, but lets get one working correctly in the way that we'd like first. There's also a good chance a lot of your work in one could be externalized to composables.

I'm testing this now.

[dessalines]

Any updates?

[vijaykramesh]

Sorry I've been out of the country, will close this out for the time being and aim to come back to it next month.