jerboa icon indicating copy to clipboard operation
jerboa copied to clipboard

Allow setting a different font size for comments

Open Elbullazul opened this issue 2 years ago • 7 comments

The default 16px font size is OK for most of the UI, but comments have almost double the font size. Would it be possible to change font size only for the comments?

Elbullazul avatar Jun 02 '23 20:06 Elbullazul

Here's an example: Screenshot_20230602-161146

The community font size is pretty small, and even the post title is smaller than the comment font size

Elbullazul avatar Jun 02 '23 20:06 Elbullazul

I have the same problem. I think this is a bug we are experiencing. From what i can tell, it's due to the comments not "reacting" to the android font setting, while the rest of the UI does. I use the smallest font size on Android, which makes this a lot worse. @Elbullazul what font size you use in your Android settings?

Nisker avatar Jun 03 '23 08:06 Nisker

I have the same issue with app, and I use the second smallest font size.

Tavius02 avatar Jun 03 '23 09:06 Tavius02

This has to do with the markdown renderer jerboa is using, not really working great with jetpack-compose sizing, but also being the only one that handles images properly.

I had a PR out to replace it with a better one, but images don't work well on that one.

Rather than having a custom font size just to support that older library, I'd rather just get the new one working properly.

dessalines avatar Jun 04 '23 21:06 dessalines

Marking this as enhancement. Even though the text size is better now with the new markdown renderer, we eventually want to support customizing for sizes for at least a few major UI components.

twizmwazin avatar Jun 09 '23 16:06 twizmwazin

Hrm. I noticed the comments are a bit small right now, but I suppose with the new markwon, its using bodyLarge. Perhaps all we need to change is that. We also need to verify that its actually using that: there's a chance its getting ignored.

I'd definitely prefer just a single font size, so that all titles, bodies, etc can scale accordingly. Otherwise it could get complicated very quickly.

dessalines avatar Jun 09 '23 16:06 dessalines

Hrm. I noticed the comments are a bit small right now, but I suppose with the new markwon, its using bodyLarge. Perhaps all we need to change is that. We also need to verify that its actually using that: there's a chance its getting ignored.

I'd definitely prefer just a single font size, so that all titles, bodies, etc can scale accordingly. Otherwise it could get complicated very quickly.

I might be missing some context, or maybe there is a bug somewhere, but for me when testing on main, the comments look larger to me, not smaller.

Before (comparing against the home activity):

Screenshot_20230610_151546 Screenshot_20230610_151616

After (setting to Medium), such that the sizes looks consistent:

Screenshot_20230610_151546 Screenshot_20230610_151657

(I'm also here because I felt that the comment font size is too large, and changing font size from the app settings would then make the home activity page font size too small)

jplsek avatar Jun 10 '23 21:06 jplsek

I looked at this code again, and the markdown view should use the correct fontSize now.

dessalines avatar Feb 14 '24 19:02 dessalines