Tiling-Assistant icon indicating copy to clipboard operation
Tiling-Assistant copied to clipboard

Active window hint v2 is bad on semi transparent windows

Open EdiDD opened this issue 1 year ago • 3 comments

This active window hint v2 creates new window with given color under parent window. This behavior seems to be not optimal and is looking horribly when parent window is transparent/semi transparent causing this solution worse then before.

This looks really good. Something similar will be much better: https://github.com/forge-ext/forge

EdiDD avatar Oct 17 '24 06:10 EdiDD

This looks really good. Something similar will be much better: https://github.com/forge-ext/forge

I went with a full-sized background to handle windows with rounded edges better but I didn't consider transparent windows. How does forge do it? Do they just leave a gap between the focus hint and the rounded window edges or can they actually round the focus border for all windows properly?

Leleat avatar Oct 17 '24 11:10 Leleat

When border size is >2 it is aligned perfectly and there is no gap anywhere. It also works with transparent windows.

EdiDD avatar Oct 20 '24 14:10 EdiDD

This also works nicely: https://github.com/domferr/tilingshell

EdiDD avatar Oct 22 '24 08:10 EdiDD

What I meant is if there is an implementation the works properly in general, not just for transparent windows.

For instance, Tiling Shell only draws a border with the same rounded corners all around. But it still runs into the problem of some windows not having rounded corners or using a different radius for the roundness. For instance, here is how it looks in Tiling Shell with Firefox. The border also is drawn inside the window, which may cut off content, but that isn't really that important to make my point:

Screenshot from 2024-11-02 15-48-36

I guess there isn't a good solution to this and I need to revert to the previous behavior of potential gaps between the border and the window...

Leleat avatar Nov 02 '24 14:11 Leleat

Any progress on this ?

EdiDD avatar Dec 12 '24 15:12 EdiDD

I'll have some free time next week til the end of the year, I'll fix it then

Leleat avatar Dec 12 '24 15:12 Leleat

That's great. Can't wait to see this working :)

EdiDD avatar Dec 12 '24 15:12 EdiDD

@EdiDD I've opened https://github.com/Leleat/Tiling-Assistant/pull/386 to address this issue.

I didn't re-implement the previous version of the active window hint 1:1. Previously, I had an 'inner border' that the user could set. The 'inner border' grows into the window so that it would cover the gap between the window hint and rounded window corners. I didn't add that setting this time since that wouldn't really work with transparent windows like current state of the focus hint.

Can you test it and see if it works for you? Here are instructions on how to manually install Tiling Assistant. No problem, if you don't want to test it, I'll just merge it as is after a week or so, if I don't here anything from you anymore.

Leleat avatar Dec 19 '24 12:12 Leleat

@Leleat I have just tested it and it works well, can't see any problems. Great work . Thanks.

EdiDD avatar Dec 20 '24 09:12 EdiDD