Tiling-Assistant icon indicating copy to clipboard operation
Tiling-Assistant copied to clipboard

Tiled windows don't look tiled

Open vixalien opened this issue 2 years ago • 6 comments

When you tile a window, say to the right with Tiling Assitant, it retains the round edges and still looks as a non-tiled application.

Here's some pictures for reference

Tiled window using GNOME native tiling

image

A closer look at the bottom right edge

image

Tiled window using Tiling Assistant

image

A closer look at the bottom right edge

image

Possible solution

Now I think this can be solved by adding the relevant tiling styles to a tiled window. For example, the above extension gets the tiled-top, tiled-left and "tiled-bottom` classes.

image

Here are the relevant styles in libadwaita,

It would be nice if Tiling Assistant could add these styles too.

vixalien avatar Apr 01 '23 15:04 vixalien

This is something that can't be handled at extension level without upstream support.

A change like #239 can help in the two-tiles cases, but it won't in other cases. To support this in Ubuntu we introduced two patches:

  • Mutter: https://salsa.debian.org/gnome-team/mutter/-/blob/ubuntu/master/debian/patches/ubuntu/window-Add-ability-to-override-the-edge-constraints.patch
  • This extension: https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-tiling-assistant/-/blob/ubuntu/main/debian/patches/ubuntu/tilingWindowManager-Override-window-constraints-style.patch

They're both pretty small and the mutter one can probably be reworked to be merged upstream, but it's something we have to discuss still.

3v1n0 avatar Apr 01 '23 18:04 3v1n0

And they look as expected indeed:

image

3v1n0 avatar Apr 01 '23 18:04 3v1n0

Just wanted to come here and +1 to this since I was just about to create the same issue :)

MagnusL3D-code avatar Oct 20 '23 13:10 MagnusL3D-code

making the corners squared would solve #222

skewty avatar Dec 19 '23 16:12 skewty