luagcrypt icon indicating copy to clipboard operation
luagcrypt copied to clipboard

fix github protocol drop

Open compermisos opened this issue 4 years ago • 2 comments

lease see https://github.blog/2021-09-01-improving-git-protocol-security-github/

from 11 of january, github drop git:// protocol for un-autenticated users (most automated installs off the lib)

compermisos avatar Jan 12 '22 01:01 compermisos

Hi, thank you for your PR. It appears that since LuaRocks 3.8, git://github.com URLs are automatically converted: https://github.com/luarocks/luarocks/commit/9ff512e35455939f02eaec2318e3acc77782fdeb, so there is not an immediate need for a fix.

Did this change work for you? I would expect it to fail, shouldn't the scheme be git+https instead of https? From https://github.com/luarocks/luarocks/wiki/Rockspec-format#user-content-build_rules:

git:// - for the Git source control manager git+http:// - for the Git source control manager when using repositories that need http:// URLs https:// - for HTTPS URLs

Aside from that there are some typos in the commit message.

Lekensteyn avatar Jan 12 '22 23:01 Lekensteyn

sorry by the typos in single test, the change run in luarocks 2.4.8 the packaged version in diferents linux distro, is minor of 2.5.0

compermisos avatar Jan 14 '22 16:01 compermisos