RaidCrawler icon indicating copy to clipboard operation
RaidCrawler copied to clipboard

Published 20 hours ago • verified publisher icon LegoFigure11

"Once" Rewards affecting Filters

Open jnovack opened this issue 2 years ago • 4 comments

Describe the bug For events, there is a "once" award (e.g. for Cinderace, it is an Ability Patch). Even after completing the event, the "once" award is still calculated in filters despite not being available.

To Reproduce

  1. Complete the Cinderace event.
  2. Perform a search on "2x Ability Patches"
  3. You will be stopped on a raid in a few searches.
  4. Perform raid, only 1x Ability Patch is dropped.

Expected behavior I don't expect the filters to hit the "once" awards at all (option?, thoughts?)

image

jnovack avatar Jan 14 '23 18:01 jnovack

Well, I don't know general consensus here tbh. I was under the assumption that people would be fine hitting it once as well (maybe i am mistaken however?)

architdate avatar Jan 16 '23 09:01 architdate

If you have a filter for 2 APs for a raid you want to farm, and this raid has a "once" AP and a "permanent" AP, it will trigger.

If you have done the event, you no longer get the "once" AP despite the reward showing up every time. Thus, making the 2 AP filter effectively useless as it will hit nearly every day skip.

The work-around is to never count the "Once" items in filter calculations.

jnovack avatar Jan 16 '23 09:01 jnovack

I know the workaround for it, I just am not sure if I should implement it. While it may seem like a good idea in context of an event like Cinderace/Charizard/Greninja, it is possible that random raids also have "Once" rewards. You cannot then farm for these rewards anyway since the raid will disappear (for potential non 7* raids with "Once" in their reward tables).

The solution for this however can be to read RAM to figure out if this "Once" has been triggered or not and then count accordingly. This can even make the display of rewards more intuitive since it wont have stuff like Once written next to the reward anymore, it will be exactly what the user sees.

architdate avatar Jan 16 '23 09:01 architdate

The solution...

Well, yeah, of course, that's why I suggested the work-around until the solution is found. And if you are unsure the workaround should be implemented for all users, we have this beautiful new options tabular form, turning it off or on could just be a checkbox.

jnovack avatar Jan 16 '23 16:01 jnovack