Leif Åstrand

Results 250 comments of Leif Åstrand
trafficstars

I'm also not sure about the naming. I'm treating `whileAttached` more as a discussion starter and less as a definite proposal. I'm not sure about "lifecircle" either - it seems...

> chaining is not really that much different from just explicitly calling `Component::addUiDetachCallback`. There's a massive difference: state. If the thing you're initializing returns a registration object or if you...

An alternative way of reaching the same benefits would be to reuse the existing entry points (`onAttach` and `addAttachListener`), but supplement them to also support this particular use case. Carrying...

Yet another commonly needed feature is related to cleanup. Adding a regular attach listener returns a registration that can be used to remove the attach listener. In this particular case...

I spotted yet another typical example where this would be useful: https://cookbook.vaadin.com/ui-eventbus

Yet another use case: https://gist.github.com/OlliTietavainenVaadin/dbbec3ad7629b9292030b93d24d2dd33#file-helloworldview-java-L37-L49

Workaround for the issue that pending changes in the TextArea won't be sent to the server with `setCloseOnEsc(true)`.

Seems like you would end up duplicating this extra condition for every `@PreserveOnRefresh` in all applications. I wonder if it would make sense to fix this from the opposite direction...

The mentioned example with `AceEditor` seems like a special case since it uses a custom mechanism for loading static resources instead of relying on the mechanisms provided by Vaadin, such...

From another point of view, the "problem" here is that Vaadin is a single-page application framework that uses the browser's History API (aka `pushState`) to manipulate browser URLs in a...