"Question-mark" titled icon is not a question mark

[lt83870]

See: https://github.com/Legal-and-General/canopy/blob/master/projects/canopy/src/assets/icons/question-mark.svg

You may want to call this icon "filled-circle" instead or you may want to change it to be an actual question mark. Image or title should be changed.

[alexcanning]

It looks as though the question mark itself has been lost - this is what it should look like:

[pauleustice]

@paul-request To look into this with @alexcanning

[michelleallendavey]

Sorry to throw a curveball @alexcanning @paul-request @Xinchro but this icon already exists in the library as query-fill

https://github.com/Legal-and-General/canopy/blob/master/projects/canopy/src/assets/icons/query-fill.svg

We don't actually have one called question-mark in the Figma library. So I guess this issue involves checking if there are any uses of question-mark, replacing them with query-fill and deleting question-mark?

[paul-request]

Weirdly it is being used on OSS, so assume they are just seeing a circle then 🤔

[pauleustice]

Sounds like an accurate assessment @michelleallendavey. @paul-request Are you able to liaise with OSS devs to check what they are expecting from the use of the question mark svg? Then need to remove the question mark from the library.

[pauleustice]

This broke in December 2020. Think it's safe to say we can just remove it.

[pauleustice]

PR #1421 will fix this