Lefteris Karapetsas

Results 329 comments of Lefteris Karapetsas

Also support all changes via this upgrade: https://www.blog.eigenlayer.xyz/mainnet-launch-eigenlayer-eigenda/ Where restaking is now enabled and eigenpod needs upgrading. All the restaking events, withdrawal events, delegating events etc.

``` rotkehlchen/tests/unit/test_optimism_inquirer.py::test_optimism_nodes_prune_and_archive_status ``` is unrelated. These tests that query prune/archive status are flaky as heck. We should probaly remove them. Their purpose is not clear to me and makes no...

I also have the same question. Would there be a way to repeat some tasks, but abort others when they fail?

> Thanks! I've left a few suggestions below. > > Main points: > > * It's PEP 585, not PEP 584 :) > * Stick to * `type` is a...

> You need to update the title of the PR as well ;) Done! > Thanks! A few more points: Addressed them and pushed. One question from my side. [Here](https://github.com/python/mypy/pull/14246#discussion_r1038989681)...

> > One question from my side. [Here](https://github.com/python/mypy/pull/14246#discussion_r1038989681) I asked you if you know the sphinx link to type for the docs. Any idea? This does not seem to render...

> Looks great now! Just two minor points: Addressed both. And also opened that follow-up PR.

> It's a bit weird to frame this around PEP 585, when PEP 585 doesn't really do anything special here: you can run into the exact same problem with types...

I also wanted to ask here, when you have a class variable as an "immutable" constant for that class, what should you do? Should you still annotate with this? Is...

Just adding my proverbial +1 request for this feature :pray: