element-tiptap icon indicating copy to clipboard operation
element-tiptap copied to clipboard

Published 20 hours ago • verified publisher icon Leecason

Develop

Open medzhidov opened this issue 3 years ago • 6 comments

I wrote you email several days before, ignore it, this is another repository without troubles described in email.

So there is only benifits without cons:

  • Updated iframe plugin (make it resizable, selectable and editable, parse inserted url to be sure that youtube\vimeo\twitch etc. links is really embed link)
  • Updated image plugin (paste image from clipboard, save aspect ratio on resize)
  • Made several icons more UX intuitive
  • Floating menu (FUCK YEAH! https://github.com/Leecason/element-tiptap/issues/58)
  • Headers in a several single buttons (H1\H2\H3, good tiptap feature that was lost in element-tiptap and it really useful with floating menu)
  • Fixed https://github.com/Leecason/element-tiptap/issues/272
  • Fixed bug when terser plugin change all components names into "<\I>" and vue throws non-critical errors

I hope this will helpful for your work =)

medzhidov avatar Dec 09 '20 23:12 medzhidov

Maybe deletion of yarn.lock is a bad idea for your project, but if you try to clone your current master now and start yarn serve (after clean yarn install of course), this will not working. But with clean npm install the serve command works perfect.

medzhidov avatar Dec 10 '20 00:12 medzhidov

it is a pity that the repository owner is not active, mainly in case of this updates.

Draccano avatar Dec 14 '20 02:12 Draccano

Hi @medzhidov, thanks for your awesome develop, could you split this code into multiple features PR?

Leecason avatar Dec 14 '20 13:12 Leecason

it is a pity that the repository owner is not active, mainly in case of this updates.

sorry, I've been a bit busy with work recently.

Leecason avatar Dec 14 '20 13:12 Leecason

@Leecason, okay, will do it in a free time, but help me with yarn trouble: does all works correctly if you clone your project and start yarn install -> yarn serve -> yarn build:lib? All scripts works correctly on clean repository? And what global yarn version do you use

medzhidov avatar Dec 14 '20 14:12 medzhidov

Unfortunately i have no time in near future. Make PR for each improvement it is a lot of bureaucracy work. In this PR all features divided primarily by commits, so each commit is a separate feature\fix. You can pull all commits what you need and update your repo. Thank you for understanding

medzhidov avatar Dec 15 '20 23:12 medzhidov