LeeTibbert
LeeTibbert
I think this method from `String.scala` also hits our checklist. I had originally been concerned with the scary looking non-JVM sb.getValue() when I saw the sb.length. I think this can...
Having the concrete code of the 'showcase' is helpful. You have put a lot of thought and effort into the code and the benefit shows. 1) In studying that code,...
David, > I think that some tests in probably just StringBuilder If you concur with the idea, would you like me to write the tests I described? `StringBuilderTest` if such...
Thank you for patiently answering my questions. I think the summary is that once some unit-tests for potentially mutated strings are written, this PR should proceed to at least CI....
> f you can do that I would be very grateful. OK, so once I am done with the "string immutability" tests, I will clone the code this PR and...
domaspoliakas Thank you for this contribution. I hope it is the first of many. Overall, it looks very good. It is nice to see the corresponding & careful Tests. I...
To allow my mind to rest and focus on my current project, I did a spot test of perhaps 3 failing tests. They were all the same: ``` while (i...
As promised, FYI: https://alvinalexander.com/scala/how-to-define-equals-hashcode-methods-in-scala-object-equality/ I found this article helpful. In it Alvin references at least two of his original sources. Alvin is careful and informed, not "just some joe off...
Any idea what the chance of a hash collision is from "concatenationOfAllFields".##? I sure do not know and have no idea how to figure that math. Likely to be relatively...
I suggest putting that behavior under a DEBUG flag/configuration_option and keeping the "normal" behavior as specified by the JVM. Thanks for the info.