Lee Hampton

Results 22 comments of Lee Hampton

Hi @curlup . you make a good point that the `bigint` type and nanosecond precision may be a bit overkill. Ideally we could keep the schema flexible enough to handle...

@hbs By testing download do you mean benchmarking things like getting a remote database dump?

Great suggestion @hbs . Adding UPDATEs and DELETEs is on our shortlist of functionality to test across DBs, even more so with regulations like GDPR now fully in place. Feel...

@seanmalloy Definitely! I'll get it hooked up on dev within the next day or two and let you know if I run into anything weird.

@seanmalloy && @Quentin-M I'm running into issues with this in my stack. The change to use the `node-role.kubernetes.io/node` label instead of the `kubernetes.io/role` label causes all of my existing records...

I'm wondering if it might make more sense to change the `--node-port-node-role` flag to a key value pair so we have control over both the label and value we filter...

@Quentin-M makes sense. I opened a PR against your PR [here](https://github.com/Quentin-M/external-dns/pull/1). This implements a basic single label setup, which I tested against my cluster and works beautifully. However, I do...

@Quentin-M Sent another [PR](https://github.com/Quentin-M/external-dns/pull/2) your way that builds on this. Now you can use the full label selector syntax, and the parsing is handled by the k8s `labels.ConvertSelectorToLabelsMap()` function. This...

What can we do to get this reviewed and merged? Don't want this to fall into a languishing state again like it did last Fall. 😄 cc @Quentin-M @seanmalloy &&...