ledger-live-desktop icon indicating copy to clipboard operation
ledger-live-desktop copied to clipboard

WalletConnect - Ethereum Goerli in dev mode

Open bberz-groma opened this issue 2 years ago • 0 comments

🦒 Context (issues, jira)

  • Adds logic to AccountHeaderActions.js to determine if developer mode is enabled
  • If enabled, test nets can be added to a walletConnectNetworks array that consists of the baseNetworks (["ethereum", "bsc", "polygon"];). In this PR, the networks would be ["ethereum", "bsc", "polygon", "ethereum_ropsten", "ethereum_goerli"];

💻 Description / Demo (image or video)

https://user-images.githubusercontent.com/100605721/169877006-58d0a629-d733-4cb5-ba38-88d2833e389c.mov

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • [ ] a specific test planned is defined on Jira
    • [x] this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • [ ] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • [x] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

bberz-groma avatar May 23 '22 17:05 bberz-groma