ledger-live-desktop icon indicating copy to clipboard operation
ledger-live-desktop copied to clipboard

Published 20 hours ago • verified publisher icon LedgerHQ

[LL-8723] [LL-8792] [LL-8793] - Discover navigation (recently used apps, category filters)

Open ofreyssinet-ledger opened this issue 2 years ago • 1 comments

🦒 Context (issues, jira)

LL-8724 LL-8723 LL-8793

Figma for reference

💻 Description / Demo (image or video)

some notable differences with the design:

  • for now the filter checkboxes are using the old design (blue checkbox) as the ones from the UI lib don’t work very well yet in this hybrid environment (pre rebrand)

Note regarding the "categories filtering + tags" and "suggested apps" features:

⚠️ Dependency on LLC-PR ⚠️ Dependency on LLA-PR

  • Before the LLC-PR is merged, the only way to test will be by using yalc (in LLC, checkout the branch of the PR, run yarn && yarn publish then in LLD run yalc add @ledgerhq/live-common && yarn && export MOCK=1 && yarn start. The MOCK=1 env variable will make LLC use mock data for the catalog metadata instead of fetching the real endpoint.
  • When LLA-PR gets merged in develop, provided that the LLC-PR is used (with yalc or a regular install), then the "staging" endpoint is live and can be fetched (go to developer settings & in "set the catalog provider" choose "staging")
  • When both PR are live and the LLC PR is integrated in this PR, everything can be tested with no particular environment setup.

Steps necessary before merge:

  • [ ] integrate a LLC release that has LLC-PR merged

🖤 Expectations to reach

  • Before dependencies are merged and integrated, it behaves as if the catalog endpoint is down: no information on promoted apps and categories: Screenshot 2022-01-07 at 16 44 46

  • When the endpoint is live and LLC dependency is integrated (or when the environment is fully setup as described above): NB: the suggested apps don't have thumbnails yet so we're using the name and icon as a temporary placeholder.

https://user-images.githubusercontent.com/91890529/148570164-a592edc3-2583-413b-a1b5-09367a5accc7.mov

  • on QA: at least one of these two checkboxes must be checked:
    • [x] a specific test planned is defined on Jira
    • [ ] this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • [ ] Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • [x] Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

ofreyssinet-ledger avatar Dec 31 '21 15:12 ofreyssinet-ledger

Coverage report

Multiple errors occurred

 1 | Failed reading coverage file. (Error: Error: ENOENT: no such file or directory, open './report.json')
 2 | Getting code coverage data failed.
St.:grey_question:
 Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run failed

Failed tests: 0/6. Failed suites: 11/13. 
  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)


  ● Test suite failed to run

    SyntaxError: /home/runner/work/ledger-live-desktop/ledger-live-desktop/tests/fixtures/common.ts: Unexpected token, expected "," (91:16)

      89 |     await page.addInitScript(() =>
      90 |       window.addEventListener("beforeunload", () =>
    > 91 |         (window as any).collectIstanbulCoverage(JSON.stringify((window as any).__coverage__)),
         |                 ^
      92 |       ),
      93 |     );
      94 |     await fs.promises.mkdir(istanbulCLIOutput, { recursive: true });

      at Object._raise (node_modules/@babel/parser/src/parser/error.js:147:45)
      at Object.raiseWithData (node_modules/@babel/parser/src/parser/error.js:142:17)
      at Object.raise (node_modules/@babel/parser/src/parser/error.js:91:17)
      at Object.unexpected (node_modules/@babel/parser/src/parser/util.js:190:16)
      at Object.expect (node_modules/@babel/parser/src/parser/util.js:150:28)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/parser/expression.js:1694:14)
      at Object.parseParenAndDistinguishExpression (node_modules/@babel/parser/src/plugins/flow/index.js:2998:20)
      at Object.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1113:21)
      at Object.parseExprAtom (node_modules/@babel/parser/src/plugins/jsx/index.js:562:22)
      at Object.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:668:23)

Report generated by 🧪jest coverage report action from 2e34ca7a94b7d3d5523451244b528e6305900102

github-actions[bot] avatar Jan 07 '22 15:01 github-actions[bot]