ledger-live-desktop icon indicating copy to clipboard operation
ledger-live-desktop copied to clipboard

Add support for ENS domains

Open Zaczero opened this issue 4 years ago • 19 comments

  • [x] I have checked this feature was not yet requested.

Currently when sending a transaction no ENS domain is being resolved. Instead I'm given the error "not a valid ... address". Would love to see this dApp being implemented into Ledger Live! :-)

200416041413_Ledger_Live_bc0c37


What is ENS?

https://ens.domains/

Why?

  • Join the list of ENS-compatible wallets
  • Stay ahead of the competing hardware wallets
  • Simplify and speed up the send transaction process

Compatible coins/tokens (multi-coin)

  • Ethereum
  • Ethereum Classic
  • Bitcoin
  • Bitcoin Cash
  • Litecoin
  • XRP
  • Dogecoin
  • Monacoin

... as of 16 Apr 2020

Possible use of text records

There is this thing called text records which contains few standardized fields:

  • Email
  • URL
  • Avatar
  • Description
  • Notice
  • Keywords
  • vnd.twitter - aka. Twitter username
  • vnd.github - aka. GitHub username

I can only imagine how cool would it be to display those details while making a transaction inside the UI. A large circled avatar preview at the top, small email address below, some links (GitHub, Twitter) and a short description (maybe?). The potential is here.

200416042804_firefox_6ee793

Zaczero avatar Apr 16 '20 02:04 Zaczero

Resolving ENS docs: https://docs.ens.domains/dapp-developer-guide/resolving-names

Zaczero avatar Apr 17 '20 17:04 Zaczero

This would be great! ENS is critical for mass adoption!

joshgaweda avatar May 14 '20 19:05 joshgaweda

yeah, unable to send to ENS domain from ledger live is really astonishing in 2020.

cyanlink avatar Sep 05 '20 12:09 cyanlink

How would you suggest the device to securely verify the address correctly correspond to that ENS domain? It's not as trivial as it seems.

gre avatar Sep 05 '20 17:09 gre

How would you suggest the device to securely verify the address correctly correspond to that ENS domain? It's not as trivial as it seems.

@gre

Okay first I assume you have the basic idea about ethereum and smart contracts. ENS system is a set of contracts (resolvers and registry and etc) that maintains the mapping record of (sub)domain and addresses and other info on the ethereum blockchain.

All Ledger Live Software has to do is to enable the ability to lookup ENS domains which can be backed by ledger proxy API, show the user the corresponding address on UI(the ledger client also need the ability to lookup for reverse record to display a human-readable ENS domain). The ledger nano device shows the address as usual so that user can check if there are MITM between ledger live and ledger nano.

If you need to make sure that the lookup result is genuine and authentic, users have to trust infura/any other ethereum gateway provider such as ledger proxy.

cyanlink avatar Sep 06 '20 14:09 cyanlink

hello! I would very much still like this feature, and I'm sad that this conversation stopped and this issue is still open :(

support for ENS will be great for adoption!!!

roddurd avatar Feb 13 '21 09:02 roddurd

+1

Reuvens avatar Feb 16 '21 09:02 Reuvens

Also interested in support for ENS.

drakedanner avatar Apr 26 '21 03:04 drakedanner

Came here to see if it was supported. +1

jamescook10 avatar May 07 '21 08:05 jamescook10

i absolutely want that

99Thebigdady avatar May 22 '21 01:05 99Thebigdady

+1

sicbitm avatar Jun 13 '21 07:06 sicbitm

+1

max-arias avatar Jul 10 '21 22:07 max-arias

+1

Jb00gy avatar Aug 27 '21 23:08 Jb00gy

+1

a186r avatar Sep 11 '21 06:09 a186r

+1

Oakoakoakoak avatar Sep 19 '21 01:09 Oakoakoakoak

+1

jasonrpoteet avatar Oct 22 '21 22:10 jasonrpoteet

+1

willianpaixao avatar Nov 10 '21 10:11 willianpaixao

ENS support in 2022 is absolutely necessary! Its critical for mass adoption.

Danielhighfive avatar Feb 02 '22 12:02 Danielhighfive

i really want that

pet125 avatar May 07 '22 14:05 pet125