Clément Grégoire

Results 98 comments of Clément Grégoire

I'm turning this PR into a draft as I will be submitting smaller PRs that split the review work

Interesting, so from what I saw, we could use the `offline_callbacks` to check that the build-id is correct ? One of the main issues I'd like to fix is the...

> As part of this refactoring, I am also inclined to move the following event definitions: > > https://github.com/wolfpld/tracy/blob/886a0abec9f5267f2bf145eb698bac80df80b27a/public/client/TracySysTrace.cpp#L83-L141 > > into the newly introduced `TracyETW.cpp` file. > Any objections?...

Interesting, so if you use both PresentMon and Tracy at the same time for example, things will be dropped?

It seems this propagated to agents, can't run them this morning, most likely due to 2.1.0

I can confirm replacing the hardcoded path with a usable one fixed subagents.

2.1.5 seems to have made things worse and patch no longer works.

I was getting such messages: > Bash(rm -rf build && > CMAKE_C_COMPILER_LAUNCHER=ccache > CMAKE_CXX_COMPILER_LAUNCHER=ccache cmake > -B build -G Ninja 2>&1 | tail -20) ⎿  Error: EACCES: permission denied, mkdir...