Lectem
Use Hunter package manager
It would probably benefit everybody to have hunter integration, but the following issues need to be addressed first :
- Clean the Stormlib CMakeLists.txt so that hunter support gets upstreamed or at least way easier to rebase than https://github.com/hunter-packages/StormLib (which is not up to date right now because of this)
- Hunterize BGFX
- Probably not that hard now that bgfx.cmake uses find_package properly ?
- Make sure that SDL2 is working properly (heard hunterized version has custom patches ?)
Is the stormlib package way out of date? I am definitely it originally, so I can update it. Are you saying that the cmakelists.txt is too divergent from the upstream?
On Dec 24, 2017 6:39 PM, "Lectem" [email protected] wrote:
It would probably benefit everybody to have hunter integration, but the following issues need to be addressed first :
- Clean the Stormlib CMakeLists.txt so that hunter support gets upstreamed or at least way easier to rebase than https://github.com/hunter-packages/StormLib https://github.com/hunter-packages/StormLib (which is not up to date right now because of this)
- Hunterize BGFX
- Probably not that hard now that bgfx.cmake uses find_package properly ?
- Make sure that SDL2 is working properly (heard hunterized version has custom patches ?)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Lectem/Worldstone/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCumoU5YZ7gID-xLDTq2LijP0YEGlpeks5tDppRgaJpZM4RL_XS .
cmakelists.txt is too divergent from the upstream
Yes, Ideally I'd like to slowly merge things into upstream. I cleaned it a bit already, but it still needs to have find_package and default fallback(to keep previous behaviour) written, I just didn't have the time to. I think that if we slowly change upstream with backward compatible changes it will get accepted.
I don't think ladik gives a shit about hunter, cmake, or anything but windows though :v. I mentioned on the stormlib issue tracker that I made a package and he just closed the issue
On Dec 29, 2017 11:39 AM, "Lectem" [email protected] wrote:
cmakelists.txt is too divergent from the upstream
Yes, Ideally I'd like to slowly merge things into upstream. I cleaned it a bit already, but it still needs to have find_package and default fallback(to keep previous behaviour) written, I just didn't have the time to. I think that if we slowly change upstream with backward compatible changes it will get accepted.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Lectem/Worldstone/issues/2#issuecomment-354435386, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCumprQIiNucHr2bJinap9ujFSQ7a_Hks5tFM9YgaJpZM4RL_XS .
That's why I said "slowly change". While he doesn't really care that much, as long as things work he merges it in. I'm not saying we should add hunter to upstream, this will probably not be approved, but we can still make it so that upstream cmake does everything else correctly, and we'd have only a few lines to change for the hunterized version.