Quentin Quadrat

Results 151 comments of Quentin Quadrat

@HemilTheRebel I've never deal with PR, but it seems you changed indentation of the original code (I had to activate the option "hide whitespace changes" to see you real changes)....

@HemilTheRebel seems good to be ! Maybe m_finalColor can be directly be a stream, this could avoid conversion stream -> string -> stream

Not exactly what you want: https://learnopengl.com/Advanced-OpenGL/Stencil-testing

Hi thank for your reply! Sorry, I was a little tired when I wrote this comment and I'm a very beginner in Python so it's more a hypothesis than concrete...

> I see your point now. It make sense but in the meantime, if you delete a texture, you're not supposed to access it anymore, no ? Yes this totally...

No problem :) Sorry for the PR I hardly know Python, so I'm not feeling comfortable to create a PR potential buggy so maybe I can post prototype of changes?

@dtrajko Hi! Is this repo https://github.com/samhocevar/portable-file-dialogs related to your Application::OpenFile() and Application::SaveFile() ? I used it and it works on my side for Linux and MacOS

pkg-config generation is managed by CMakefile. I'll check if I can make a PR from this project I helped, I'm noob with CMake: https://github.com/sebastiandev/zipper/blob/master/zipper.pc.cmakein https://github.com/sebastiandev/zipper/blob/87b14a4b31771ed94ebb3204dc6ed69ad9c78436/CMakeLists.txt#L465 https://github.com/sebastiandev/zipper/blob/87b14a4b31771ed94ebb3204dc6ed69ad9c78436/CMakeLists.txt#L479

@JohelEGP @nholthaus Could be nice to add pixel type and its conversion to meters. Of course, pixel are not yet recognize by the SI consortium ^^ but for top-down simulation...

Yes, at least the doc should refer to its name, as well as ParallelAll, to indicate its existence. I guess this is 3thd most important control node in my opinion....