openscad-support-vscode icon indicating copy to clipboard operation
openscad-support-vscode copied to clipboard

Fix syntax errors thrown with trailing comma in arg list

Open DeflateAwning opened this issue 1 year ago • 9 comments

The following is valid OpenSCAD, at least in the current preview builds:

include <BOSL2/std.scad>

zcyl(
	d=screw_d,
	h=100,
);

Note the comma after h=100.

Currently, this plugin highlights an error on that symbol ("missing identifier"). It should not report an error.

DeflateAwning avatar Nov 26 '23 19:11 DeflateAwning

The latest version of tree-sitter-openscad seems to have solved this problem, I will upgrade.

Leathong avatar Nov 27 '23 03:11 Leathong

This issue appears to still be present. Is there anything more that can be done about it?

DeflateAwning avatar Jan 15 '24 06:01 DeflateAwning

This issue appears to still be present. Is there anything more that can be done about it?

Present in the released version or the unreleased version? Considering latest release was 2023-05-24 but there has been commits here since that time

voxpelli avatar Jan 15 '24 08:01 voxpelli

Can you do a release then?

DeflateAwning avatar Jan 15 '24 09:01 DeflateAwning

Can you do a release then?

I'm not the maintainer, just trying to figure out if it's just a release that's needed or more

voxpelli avatar Jan 15 '24 09:01 voxpelli

Doesn't look like the version number on the dependency has been bumped yet. Likely need that, and then a release too

DeflateAwning avatar Jan 15 '24 09:01 DeflateAwning

The PR of tree-sitter-openscad is not merged yet.

Leathong avatar Jan 16 '24 06:01 Leathong

This PR is finally merged to the tree-sitter-openscad library! This project can finally be updated.

DeflateAwning avatar Feb 01 '24 01:02 DeflateAwning

@DeflateAwning I tried the last version 0.5.0 of tree-sitter-openscad this issue still exist.

Leathong avatar Feb 22 '24 03:02 Leathong