LeagueSandbox
Rework
This Pull Request includes a lot of content
- Changed a lot of code (Yes, that's why this is a rework)
- Champion Select: Test Pick Mode (Like Blind Pick but enemy players can see your pick ^^)
- Reconnect to Game screen (with Leave option)
- New cool desing
- Game starting works well now
- Summoners Icons!
- Removed Config File
- Updated Socket.IO version
To-Do:
- Update all dependencies
- Bring back the old "choose lobby options" menu (with stuff like banned things, map select, champion select) so that the new Champion Select: Test Pick Mode is optional
Off the top of my head, I find the whole champion select phase enforcement unnecessary. The idea originally was (and still is) that it's an optional addition and that you don't have to use it by default unless you want to.
This change enforces the champion select phase, and removes the custom game lobby like feel that initially existed, which personally I'm not a fan of. I'm afraid if this is merged in it's current state, someone has to go back the git history regardless and dig up old pieces of code to make the champion select optional.
The skin itself looks great, though it'd be nice to make sure the custom setting components still work in the new skin as well.
As for the code review, this is a massive change (not to mention it's in a single commit) so it's a tad difficult to review. I'll do it some evening with a 🍺 on my hand when I don't mind the time spent. If you want to make sure this goes through before then, you should
- Make the champion select phase optional
- Make sure the different settings components still work in the new design
