GameServer icon indicating copy to clipboard operation
GameServer copied to clipboard

Re-implement HandleGameNumber if necessary

Open LeagueSandboxBot opened this issue 7 years ago • 1 comments

Figure out if HandleGameNumber should be re-implemented and the proper way to do it. Existed earlier at https://github.com/LeagueSandbox/GameServer/blob/ce8c4e4621492ab8ea34bcfc6547fbee824d06fa/GameServerLib/Logic/Packets/PacketHandlers/Handlers/HandleGameNumber.cs#L7-L17 and https://github.com/LeagueSandbox/GameServer/blob/de2e46e36edaa4885f60610a284352c8ddde0839/GameServerLib/Logic/Packets/PacketHandlers/Handlers/HandleKeyCheck.cs#L25-L60 Removed by #494


Beep, boop, I'm a bot! This issue was created by @Mythic in #game-server.

LeagueSandboxBot avatar Aug 22 '17 15:08 LeagueSandboxBot

HandleKeyCheck is handled correctly in the packets project. World_SendGameNumber is currently indeed not handled anymore, but it seems unimportant. This packet just sends the GameId and the SummonerName, probably to track the current players in the client/outside of the game. To implement it just use https://github.com/LeagueSandbox/LeaguePackets/blob/master/LeaguePackets/Game/146_World_SendGameNumber.cs probably after recieving StartGame packet or Sync packet.

danil179 avatar May 07 '21 11:05 danil179