fvtt-module-furnace
fvtt-module-furnace copied to clipboard
League-of-Foundry-Developers
Add support for splitting nested journals
Closes #73
This allows the user to journals across multiple levels of hierarchy. The user specifies the upper and lower bounds of the split.
If the upper and lower are set to the same value, I've confirmed that functionality remains identical to the current state.
I want to say that "it looks good" but honestly, my brain is mush right now and I have a little bit of trouble following.. I don't see any issues with it though apart from "Split Depth" being very unintuitive and even with reading the code, I'm not entirely sure how it's supposed to work from a user experience perspective.
I think that (if it's doable) having a better description for that would help.. also, I think that the preview which shows which new entries will be created is also going to be inaccurate if depth is not selected. I'd also probably say that second combobox should have its first element be an empty option or one that say "do not recursively split" or something to that effect.
Fair enough. Let me try and simplify/clarify the user experience, and I'll update the PR.
On Mon, Oct 26, 2020 at 7:09 PM Youness Alaoui [email protected] wrote:
I want to say that "it looks good" but honestly, my brain is mush right now and I have a little bit of trouble following.. I don't see any issues with it though apart from "Split Depth" being very unintuitive and even with reading the code, I'm not entirely sure how it's supposed to work from a user experience perspective.
I think that (if it's doable) having a better description for that would help.. also, I think that the preview which shows which new entries will be created is also going to be inaccurate if depth is not selected. I'd also probably say that second combobox should have its first element be an empty option or one that say "do not recursively split" or something to that effect.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kakaroto/fvtt-module-furnace/pull/77#issuecomment-716931190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5PM7SHAD2C6KNYUYXS4IDSMYTV5ANCNFSM4S6M26FQ .