Leaflet.markercluster icon indicating copy to clipboard operation
Leaflet.markercluster copied to clipboard

Published 20 hours ago • verified publisher icon Leaflet

Do not rely on global L

Open m1gu3l opened this issue 5 years ago • 14 comments

Should fix #874

m1gu3l avatar Jan 21 '20 13:01 m1gu3l

Wicked! ;) I have no time to test it right now, but I will eventually. Interesting to see what @IvanSanchez has to say to it.

The whole leaflet ecosystem needs a serious ES6 overhaul with a major new release.

pke avatar Jan 23 '20 11:01 pke

@IvanSanchez is there any way to get your review on this? That'd be awesome!

ivansieder avatar Aug 21 '20 09:08 ivansieder

I am sorry for bumping this, but is there any news?

frafra avatar Oct 10 '21 10:10 frafra

Any way to get this merged? Thanks.

jacobweber avatar Mar 12 '22 06:03 jacobweber

@ykzeng sorry to bother you, but could you please provide feedback on this PR?

frafra avatar Mar 12 '22 18:03 frafra

Works great for me :+1:

Schleuse avatar Mar 14 '22 16:03 Schleuse

Using this change in our fork since ages.

JayceeZ avatar Mar 14 '22 17:03 JayceeZ

@mourner could you make me a collaborator so I can review PRs on this repo?

jonkoops avatar Jul 23 '22 19:07 jonkoops

@mourner could you make me a collaborator so I can review PRs on this repo?

@jonkoops still interested in this? I would be happy to check if I can add you

ykzeng avatar May 22 '23 21:05 ykzeng

Hi @IvanSanchez could you kindly help review this to make sure this is compliant with the plugin guideline? Would love to merge this or hear from you otherwise, I can certainly help if any other update will be needed as you might suggest.

ykzeng avatar May 22 '23 22:05 ykzeng

I am currently too busy with work on core Leaflet, so I will not have time to review this work anytime soon. I do intend to refactor most if not all of the official Leaflet plugins once we have a solid idea of what the API surface for Leaflet 2.0 will be.

jonkoops avatar May 23 '23 08:05 jonkoops

np @jonkoops let's stay in touch if you need any help hand

ykzeng avatar May 23 '23 14:05 ykzeng

@m1gu3l Thank you for your PR. After over a day of pulling my hair out trying to figure out why clustering was so broken between remix, react-leaflet-cluster, and leaflet.markercluster, your solution worked perfectly on the first try.

I was able to use it by :

  • manually apply your changes to a fresh fork of the latest main, (build/rollupconfig.js)
  • force installing @rollup/plugin-inject
  • building the js
  • publishing the whole package including the built js back to github and installing from there instead

Here's hoping the issue can be resolved in the package itself, at which point I can switch back and nuke the fork.

chintal avatar May 09 '24 10:05 chintal