Leaflet.label icon indicating copy to clipboard operation
Leaflet.label copied to clipboard

Add 'top' and 'bottom' directions.

Open connor opened this issue 11 years ago • 14 comments

Possible fix for #47 (fyi @ryansit, @astetik).

Wanted to put this up and see what you thought. Some of the CSS could be cleaned up a bit.

screen shot 2013-11-26 at 12 56 32 am

What do you think?

connor avatar Nov 26 '13 07:11 connor

Like it!

ryansit avatar Nov 26 '13 07:11 ryansit

Awesome work. I'll check it out later this week. Will need to check how well it interacts with the labelAnchor marker option and the L.Label offset options.

jacobtoye avatar Dec 01 '13 20:12 jacobtoye

Does this support auto top and bottom?

On Dec 1, 2013, at 10:36 AM, Jacob Toye [email protected] wrote:

Awesome work. I'll check it out later this week. Will need to check how well it interacts with the labelAnchor marker option and the L.Label offset options.

— Reply to this email directly or view it on GitHub.

ryansit avatar Dec 01 '13 20:12 ryansit

Cool, thanks @jacobtoye. I'm traveling today so I'll make the changes later this evening or tomorrow.

@ryansit - no, the existing auto logic is the same. Not sure what the desired behavior is or how we should set up the API to specify which direction the auto should fallback to, you know? Would love to hear some feedback if you have any strong feelings.

connor avatar Dec 01 '13 21:12 connor

I'm traveling too. Without diving into the code, right now there is left, right and auto. You added top bottom. Probably need autovertical that works like the other auto. The horiOntal auto seems to work with the middle point being the switch.

On Dec 1, 2013, at 11:38 AM, Connor Montgomery [email protected] wrote:

Cool, thanks @jacobtoye. I'm traveling today so I'll make the changes later this evening or tomorrow.

@ryansit - no, the existing auto logic is the same. Not sure what the desired behavior is or how we should set up the API to specify which direction the auto should fallback to, you know? Would love to hear some feedback if you have any strong feelings.

— Reply to this email directly or view it on GitHub.

ryansit avatar Dec 01 '13 22:12 ryansit

+1 for this feature

fwitzke avatar Dec 18 '13 17:12 fwitzke

definitely would be nice to have.

MikeTommasi avatar Mar 18 '14 20:03 MikeTommasi

+1 for this feature! Have someone start already the implementation?

wattnpapa avatar Aug 26 '14 12:08 wattnpapa

This seems like something I could definitely use. I was looking into using Rrose to give me automatic positioning for marker popups, but this may work as well. Basically, I want the popup to determine its own direction that will not cause the map to pan when it pops up.

RobbieTheWagner avatar Aug 26 '14 21:08 RobbieTheWagner

For popups I would use Leaflet.Rrose. This pull needs to be updated to get to a stage that it can be merged.

jacobtoye avatar Aug 29 '14 20:08 jacobtoye

I'd really like this! :+1:

tomasfejfar avatar Nov 19 '14 15:11 tomasfejfar

I want to add various label justification and rotation(angle) from the origin point together..

label_small

Taekjoon avatar Nov 06 '15 05:11 Taekjoon

Any update about this feature ?

gotvitch avatar Mar 09 '16 15:03 gotvitch

👍

jasonbaik avatar Jul 07 '16 07:07 jasonbaik