Leaflet.draw icon indicating copy to clipboard operation
Leaflet.draw copied to clipboard

Unable to edit circle

Open WaleedTayeb opened this issue 5 years ago • 2 comments

  • [x] I'm reporting a bug, not asking for help
  • [x] I've looked at the documentation to make sure the behaviour is documented and expected
  • [x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
  • [x] I've searched through the issues to make sure it's not yet reported

How to reproduce

  • Leaflet version I'm using: 1.5.1
  • Leaflet Draw version I'm using: 1.04
  • Browser (with version) I'm using: Chrome v.75
  • OS/Platform (with version) I'm using: MacOS 10.14.4
  • Create a circle
  • Edit the circle by adjusting the edit circle handle.

What behaviour I'm expecting and which behaviour I'm seeing

Expecting

  • The circle should increase or decrease in size.

What I see: image

What I propose as the fix: Radius is not defined in this line: https://github.com/Leaflet/Leaflet.draw/blob/develop/src/edit/handler/Edit.Circle.js#L31

I propose declaring the variable in order to avoid this error var radius; in this line: https://github.com/Leaflet/Leaflet.draw/blob/develop/src/edit/handler/Edit.Circle.js#L25

WaleedTayeb avatar Jul 14 '19 13:07 WaleedTayeb

I think it was a missing variable declaration, should be fixed with this PR: https://github.com/Leaflet/Leaflet.draw/pull/1053

poet-of-the-fall avatar Nov 11 '22 08:11 poet-of-the-fall

Unfortunately this seems a dead project. Stopped since 2018 with over 80 active PR but there is no user with write access to approve and merge them :(

Luperco avatar Jul 18 '23 13:07 Luperco