prefixfree icon indicating copy to clipboard operation
prefixfree copied to clipboard

Update prefixfree.dynamic-dom.js

Open simonkcleung opened this issue 12 years ago • 2 comments

Fix to https://github.com/LeaVerou/prefixfree/issues/120

simonkcleung avatar Nov 23 '13 15:11 simonkcleung

Hi there, Thanks and sorry for the huge delay. What is this PR about? There seems to be very little explanation and a very large diff.

LeaVerou avatar Jan 05 '16 17:01 LeaVerou

Line 58, Line 63

Checking (prefixed in proto) is not correct because proto is not a list of CSS properties.

The prototype of style "proto" in Chrome/Edge: document.documentElement.style.constructor = CSSStyleDeclaration(){} in FF: CSS2Properties(){} in IE: MSStyleCSSProperties(){}

List of CSS properties: Object.getOwnPropertyNames of in FF: proto.prototype in Chrome/IE: document.documentElement.style

Setting of unprefixed properties to proto:

Prefix in FF is e.g. MozAnimation in Chrome : webkitAnimation in Edge: webkitAnimation and msAnimation??? in IE: msAnimation

Need further review for Edge.

The getter and setter functions could be placed outside the for loop for better performance.

simonkcleung avatar Jan 06 '16 16:01 simonkcleung