inspire.js icon indicating copy to clipboard operation
inspire.js copied to clipboard

Gestures

Open nono opened this issue 13 years ago • 15 comments

Hi,

I've added support for gestures on smartphones (see #3). In therory, it should work on firefox, android, ios safari and blackberry if I believe http://caniuse.com/#feat=touch but I don't have the devices to test them all.

nono avatar Oct 04 '12 23:10 nono

Hi nono,

Sorry for the delay in getting back to you. This looks great and it's a long overdue feature, thank you!! Do you have any demo anywhere so that I could test it a bit before I merge?

Thanks!

LeaVerou avatar Oct 30 '12 08:10 LeaVerou

Hi,

no problem, you can test it on http://blog.menfin.info/Presentations/20121018_Mobile_apps/ .

nono avatar Oct 30 '12 09:10 nono

Hey, thanks. Which devices have you tried this on? I just tried it on my iPhone and I can't seem to get it to work.

LeaVerou avatar Oct 30 '12 09:10 LeaVerou

Firefox and chrome on an android device, and chromium on my desktop by emulating touch events.

nono avatar Oct 30 '12 09:10 nono

It doesn't seem to be working at all on iOS. If it will help, I can send you my browserstack info so you can test it for yourself. :)

LeaVerou avatar Oct 31 '12 17:10 LeaVerou

Yup please, it's better than nothing ;-)

nono avatar Oct 31 '12 17:10 nono

Well, it works but it was very difficult to trigger the gestures on iphone. I've changed some parameters and I hope it's better now. You can try the new version on http://www.menfin.info/csss/. Does it work on a real device?

By the way, the current geasture for moving to the next slide is a move from left to right. And right to left for moving to the previous slide. But maybe, the inverse is better. What do you think?

nono avatar Oct 31 '12 19:10 nono

@LeaVerou: I'm sure you are busy, but if you find some time to test it, please let me know.

nono avatar Nov 18 '12 10:11 nono

Hi Lea, did you find the time to test it?

nono avatar Jan 24 '13 13:01 nono

Sorry not yet :( But thanks for reminding me.

LeaVerou avatar Jan 24 '13 13:01 LeaVerou

Hi @LeaVerou, this is a new reminder for this pull request. I hope you will have some time for it this time.

nono avatar Jun 30 '13 15:06 nono

@LeaVerou this is yet another remainder. Maybe you have some time for it now.

nono avatar Oct 11 '13 21:10 nono

Shit, I’m so, so sorry I haven't reviewed this yet. :(

Btw there are merge conflicts now it seems. Could you please pull in any changes and resolve the merge conflicts? There shouldn't be many.

Again, thanks so much for this and I'm sorry I'm being so busy :(

LeaVerou avatar Oct 11 '13 22:10 LeaVerou

Don't worry, I know what it is to have a lot of stuff ;)

I've rebased my commits and fix the conflicts (they were trivials). So, you should be able to merge them without pain.

nono avatar Oct 12 '13 20:10 nono

@LeaVerou a quick remainder

nono avatar Dec 14 '13 23:12 nono