css3test icon indicating copy to clipboard operation
css3test copied to clipboard

Adding `min/max/fit-content` and `fit-content()` values to `flex-basis` and `flex`

Open yisibl opened this issue 1 year ago • 2 comments

  • MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis
  • Chrome status: https://chromestatus.com/feature/5635933158244352

yisibl avatar Jul 17 '24 15:07 yisibl

@LeaVerou PTAL, thanks!

yisibl avatar Jul 19 '24 03:07 yisibl

Btw. regarding the state of the fit-content keyword vs. the fit-content() function, I just filed https://github.com/w3c/csswg-drafts/issues/10601.

Sebastian

SebastianZ avatar Jul 19 '24 22:07 SebastianZ

Chrome recently started implementing the stretch keyword, so I've added it to this PR as well.

https://chromium-review.googlesource.com/c/chromium/src/+/5985742

image

yisibl avatar Nov 05 '24 12:11 yisibl

@SebastianZ It makes sense to add separate tests to flex properties to help users more visually see how they are supported in different properties.

yisibl avatar Nov 05 '24 12:11 yisibl

@SebastianZ It makes sense to add separate tests to flex properties to help users more visually see how they are supported in different properties.

I'm still not totally happy with this, but given that Chrome explicitly implements it for flex-basis and flex, I guess it's ok.

Though we should ensure the values are also tested in the Box Sizing specs for other properties.

Sebastian

SebastianZ avatar Nov 06 '24 11:11 SebastianZ