WikibaseIntegrator icon indicating copy to clipboard operation
WikibaseIntegrator copied to clipboard

v0.12.0: write_required returns True when no write is required

Open dpriskorn opened this issue 2 years ago • 3 comments

bild code is here https://github.com/internetarchive/wcdimportbot/blob/00dc45896d7e85e96f934bd13be2e9c6931cda17/src/models/wikibase/crud/update.py#L117

dpriskorn avatar Jul 19 '22 20:07 dpriskorn

I could try to provide a few lines reproducing the issue. Or a new test that fails.

dpriskorn avatar Aug 23 '22 19:08 dpriskorn

I'll check this next weekend.

LeMyst avatar Aug 25 '22 19:08 LeMyst

James seems to have found a nice solution by simply comparing the json before/after😀 image

dpriskorn avatar Nov 22 '22 06:11 dpriskorn