fix(extras.lang): fix Scala extra by using nvimMetals only
Description
Scala lang Extra should NOT be configured via neovim/nvim-lspconfig. This PR removes neovim/nvim-lspconfig config and replace it by nvim-metals only. From nvim-metals README.md: "NOTE: This plugin works without needing to install neovim/nvim-lspconfig. If you have it installed for other languages, that's not a problem, but make sure you do not have Metals configured through nvim-lspconfig while using this plugin"
Related Issue(s)
No specific issue, this is attempt to follow users guide of Scala nvim plugin : https://github.com/scalameta/nvim-metals
Screenshots
Checklist
- [x] I've read the CONTRIBUTING guidelines.
I was confused at first time using scala extras too, then I found:
https://github.com/LazyVim/LazyVim/blob/859646f628ff0d99e6afe835ba0a48faed2972af/lua/lazyvim/plugins/extras/lang/scala.lua#L68-L68
https://github.com/LazyVim/LazyVim/blob/0b6d1c00506a6ea6af51646e6ec7212ac89f86e5/lua/lazyvim/plugins/lsp/init.lua#L100-L108
https://github.com/LazyVim/LazyVim/blob/0b6d1c00506a6ea6af51646e6ec7212ac89f86e5/lua/lazyvim/plugins/lsp/init.lua#L200-L202
It's not configured via neovim/nvim-lspconfig I think. I'm not sure why it configured in neovim/nvim-lspconfig, may be for capabilities of cmp/blink and other stuff.
This PR is stale because it has been open 30 days with no activity.
Hi @folke, May I know if we need any further review to merge this PR? It's been here for quite a long time
This PR is stale because it has been open 30 days with no activity.
After update, looks like the file type can't trigger metal lsp. Hope this will be solve asap
After update, looks like the file type can't trigger metal lsp. Hope this will be solve asap
I'll verify this. Do you have any additional config related to metals?
After update, looks like the file type can't trigger metal lsp. Hope this will be solve asap
I think the cause could be Telescope is missing, will look into it soon
After update, looks like the file type can't trigger metal lsp. Hope this will be solve asap
I'll verify this. Do you have any additional config related to metals?
Just the latest LazyVim without any config about metals or scala.
If I open a scala file with nvim a/b/c.scala under a mill project, this lsp can't be triggered.
If I open the directiry nvim . with oil.nvim and then navigate to the file and open it, lsp get triggered.
After update, looks like the file type can't trigger metal lsp. Hope this will be solve asap
I'll verify this. Do you have any additional config related to metals?
Just the latest LazyVim without any config about metals or scala.
If I open a scala file with
nvim a/b/c.scalaunder amillproject, this lsp can't be triggered.If I open the directiry
nvim .withoil.nvimand then navigate to the file and open it, lsp get triggered.
oh, I got it. This PR is not merged yet so the issue you faced is not related to this PR