Pokemon-Terminal icon indicating copy to clipboard operation
Pokemon-Terminal copied to clipboard

Code cleanup

Open samuelhnrq opened this issue 7 years ago • 3 comments

This pull request starts the process of standardization and cleanup towards a more lint-able and pep8 compliant code.

I want to first to focus only on the obvious and the one git hates the most, spacing and lines, and the missing @staticmethod annotations, but this is not purely for aesthetics, I really want to clean the house up of all the silly defaults we have laying around so we can add more rigid linting to our CI process.

But I also want to keep the PR's focused in order for more focused discussion and consensus for each part.

samuelhnrq avatar Aug 04 '18 03:08 samuelhnrq

Pretty sure that won't work, because we're calling __str__ as if it was a static method. Maybe we should add a new method to the interface (something like def name() -> str) instead

sylveon avatar Aug 12 '18 20:08 sylveon

This could use a rebase 😅

jimmyorourke avatar Aug 12 '18 21:08 jimmyorourke

Lots of conflicts.

cclauss avatar Mar 28 '19 04:03 cclauss