whoiser
whoiser copied to clipboard
LayeredStudio
Add "encoding" option
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #104 |
| License | MIT |
How I use it is, if the response can contain special characters in an 8 bit encoding, I set "encoding" to "binary". This is similar to how node-whois module does it. It can be considered a new feature, but I don't think it's significant enough.
hey @tpimh thanks for adding this, it looks like a helpful option. It will be merged and included in the next release.
Can you add the option in the readme as well please? Maybe others would need this option too, and is easier to see it there. And possibly a test, if you know which whois server returns data in this way?
Thanks
Sure, I will be happy to add the option to readme and write a test for the server that I am using it with.
@tpimh the encoding option is set only for whoisQuery function, so it can't be used for a domain or tld query
Yes, that's correct. That is something I have noticed when writing documentation, so I will be changing this and updating this pull request.