Sylvain Hellegouarch

Results 161 comments of Sylvain Hellegouarch

Indeed ws4py doesn't do anything terribly useful with subprotocols because theye weren't a high priority. The better options would be delegate the filtering to the application itself rather than the...

Actually the tool takes a parameter in its upgrade method. Try something along: tools.websocket.protocols = ['mychat'] But this may not be sufficient and in the future having a callback for...

Hello shaxbee, Since you're using CherryPy, do you need the ws_location from the WebSocket class or in the CherryPy page handler itself?

Could we get all these commits squashed and a passing build before review please?

Agreed. This could be setup using travis indeed.

Mind squashing your commits for review? :)

Thanks a lot for the kicking the discussion on this one. I'm going to take some time to think about it because it's not a small change nor a small...

Hi there, I haven't forgotten about this PR. Just was busy elsewhere unfortunately :(

Hello @WixoLeo Thanks for the report and GH repo. But I'm confused. The settings file links to a control where everything is commented out. can you explain?