WebSocket-for-Python icon indicating copy to clipboard operation
WebSocket-for-Python copied to clipboard

Python 3.7 and 3.8 compat

Open morucci opened this issue 5 years ago • 4 comments

Fix #250

morucci avatar Mar 12 '20 10:03 morucci

python 3.3 test is failing on

$ curl -sSf --retry 5 -o python-3.3.tar.bz2 ${archive_url}
curl: (22) The requested URL returned error: 404 Not Found
Unable to download 3.3 archive. The archive may not exist. Please consider a different version.

How to fix the CI ?

morucci avatar Mar 13 '20 09:03 morucci

This is critical! how can this be shipped to pypi?

xnox avatar Jul 05 '20 00:07 xnox

Note in debian/ubuntu a better patch than this is shipped:

https://salsa.debian.org/python-team/modules/python-ws4py/-/blob/master/debian/patches/0003-Fix-compatibility-with-Python-3.7.patch

that one keeps compatibility with older pythons, as well as the newer ones.

xnox avatar Jul 05 '20 00:07 xnox

I think it is already handled in https://github.com/Lawouach/WebSocket-for-Python/commit/b03d29b502b557dbfb6ab778eaa1a04c29878def

auvipy avatar Oct 11 '23 08:10 auvipy