lawnicons icon indicating copy to clipboard operation
lawnicons copied to clipboard

Problem with icons applying

Open Vijorich opened this issue 2 years ago • 20 comments

About this discussion

Why do some icons not change even though they are in the icon pack and all links are correct?

https://user-images.githubusercontent.com/88296320/210801719-5fb48acb-d24d-4138-a2c9-66834c0516e2.mp4

Vijorich avatar Jan 05 '23 14:01 Vijorich

  • Steam (com.valvesoftware.android.steam.community)
  • Xtra (com.github.andreyasadchy.xtra)
  • Goodline (info.goodline.mobile2)
  • FixPrice (ru.bestprice.fixprice)
  • Grill one (ru.geo.ppmobile.grillone)
  • Eapteka (ru.getpharma.eapteka)
  • Paysphere (ru.nskes.paysphera)
  • SGK (ru.sibgenco.general)
  • Riseup VPN (se.leap.riseupvpn)
  • Mind Tracker (com.fedosov.mindtracker) These icons do not apply properly

Vijorich avatar Jan 06 '23 06:01 Vijorich

+1, 1password 8 as well. com.1password.android

jacksonwelsh avatar Jan 15 '23 19:01 jacksonwelsh

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it. https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

https://user-images.githubusercontent.com/7315975/214953769-0b5bdc7f-61fa-4c76-a2b6-bc2b38ff2af5.mp4

naveenccmsd avatar Jan 26 '23 21:01 naveenccmsd

For 1password:

<appfilter>

	<!-- 1Password -->
	<item component="ComponentInfo{com.onepassword.android/com.onepassword.android.app.StartActivity}" drawable="1password"/>

</appfilter>

jacksonwelsh avatar Jan 26 '23 23:01 jacksonwelsh

@jacksonwelsh , Thank you . I have added link for 1password.

https://github.com/LawnchairLauncher/lawnicons/pull/1002

naveenccmsd avatar Jan 28 '23 10:01 naveenccmsd

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it. https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

https://user-images.githubusercontent.com/7315975/214953769-0b5bdc7f-61fa-4c76-a2b6-bc2b38ff2af5.mp4

https://paste.crdroid.net/l4CdeH

https://user-images.githubusercontent.com/88296320/215277431-f765adc8-2cff-4ec4-aa8d-9840c97b51eb.mp4

Vijorich avatar Jan 28 '23 16:01 Vijorich

@Vijorich I undersnad you were facing issue with icon request app , unfortuanitly it was not owned by lawncher team, we can't fix the issue , without appcomponent details from your mobile we can't fix the icon mapping issue.

Can you try with any other apps and extract the app componenet details ? it should be something like below

<!-- 1Password -->
<item component="ComponentInfo{com.onepassword.android/com.onepassword.android.app.StartActivity}" drawable="1password"/>

Alernativy try the below app and select iconsrequest option

https://github.com/naveenccmsd/Ayan/releases/download/1.2.2/Ayan_iconpack_v1.2.2.apk or candybar dev in from playstore

naveenccmsd avatar Jan 29 '23 08:01 naveenccmsd

@naveenccmsd Steam (com.valvesoftware.android.steam.community/com.valvesoftware.android.steam.community.MainActivity) Steam.svg Goodline (info.goodline.mobile2/info.goodline.mobile2.MainActivity) goodline.svg FixPrice (ru.bestprice.fixprice/ru.bestprice.fixprice.application.root.MainActivity) FixPrice.svg Grill one (ru.geo.ppmobile.grillone/ru.geo.ppmobile.grillone.MainActivity) grillone.svg Eapteka (ru.getpharma.eapteka/ru.getpharma.eapteka.mainscreen.bottom_navigation.MainActivityWithBottomBar) eapteka.svg Paysphere (ru.nskes.paysphera/ru.nskes.paysphera.presentation_v2.screen.activity.main_activity.MainActivity) paysphera.svg SGK (ru.sibgenco.general/ru.sibgenco.general.ui.activity.HomeActivity) skg.svg Riseup VPN (se.leap.riseupvpn/se.leap.bitmaskclient.base.MainActivity) riseup_vpn.svg Mind Tracker (com.fedosov.mindtracker/com.fedosov.mindtracker.MainActivity) mindtracker.svg RuStore (ru.vk.store/ru.vk.store.app.MainActivity) rustore.svg Pyaterochka (ru.pyaterochka.app.browser/ru.pyaterochka.app.browser.BrowserActivity) pyaterochka.svg Sber mega market (ru.goods.marketplace/ru.goods.marketplace.SingleActivity) sber_mega_market.svg

Vijorich avatar Feb 17 '23 17:02 Vijorich

@Vijorich could you check if all the icons are working as intended now with the latest debug file?

Chefski avatar Mar 12 '23 21:03 Chefski

@Chefski Screenshot_20230313-045131_Sushi Launcher.png

3/12

Vijorich avatar Mar 12 '23 21:03 Vijorich

Screenshot_20230313-072335_Lawnchair (Debug)

6/9

I will check if the activities are right and the right drawable are linked

daywalk3r666 avatar Mar 13 '23 06:03 daywalk3r666

Screenshot_20230313-081947_Lawnchair (Debug) Test it with this version of lawnchair https://github.com/LawnchairLauncher/lawnchair/commit/44da9e2 If my pull request won't work for you. Try to delete app data, maybe deleting cache is enough?

Works with kvaesitso launcher too.

daywalk3r666 avatar Mar 13 '23 07:03 daywalk3r666

@Vijorich can you check the last debug apk

daywalk3r666 avatar Mar 13 '23 10:03 daywalk3r666

@daywalk3r666 Still only 3 of 12 for me in both lawnicons and kvaesitoScreenshot_20230314-081131_Sushi Launcher.png

Screenshot_20230314-081117_Sushi Launcher.png

Screenshot_20230314-081134_Sushi Launcher.png

Screenshot_20230314-081120_Sushi Launcher.png

Vijorich avatar Mar 14 '23 01:03 Vijorich

whats your current lawnchair version? because since lawnicons switched to an icon pack, my app won't work with lawnchair launcher.

daywalk3r666 avatar Mar 14 '23 04:03 daywalk3r666

whats your current lawnchair version? because since lawnicons switched to an icon pack, my app won't work with lawnchair launcher.

Screenshot_20230314-123825_Sushi Launcher.png

I have sushi launcher, which was pre installed in rom

Vijorich avatar Mar 14 '23 05:03 Vijorich

Then is launcher rated?

daywalk3r666 avatar Mar 14 '23 05:03 daywalk3r666

Perhaps a caching issue? Does this happen with a different launcher?

KTibow avatar Aug 09 '23 01:08 KTibow

Perhaps a caching issue? Does this happen with a different launcher?

Does not seem to do it. I also tried clearing Lawnchair cache (though not Lawnicons).

Seems to be a well-known problem https://github.com/LawnchairLauncher/lawnicons/issues/1154 https://github.com/LawnchairLauncher/lawnicons/issues/1722

Is this a Lawnchair issue?

Secure Folder and muPDF are not applying for me.

PathosEthosLogos avatar Feb 27 '24 10:02 PathosEthosLogos

I suggest installing Lawnchair 14 Beta 2, the latest version of Lawnicons, and let us know if the problem still occurs.

x9136 avatar Apr 23 '24 07:04 x9136