lawnchair icon indicating copy to clipboard operation
lawnchair copied to clipboard

At a glance cropped for Smartspacer

Open sarojpanda44 opened this issue 11 months ago • 14 comments

Describe the bug

I'm using Smartspacer as At a glance provider and the Smartspacer is cropped on each side. In version #314 the margin crop was minor (ignorable) but in version #450 it's too much cropped.

Difference is the Pixel launcher home screen grid is 5x5 and in Lawnchair the home screen grid is 5x6.

It is fixed if I change the grid to 5x5 but I prefer to have more rows and want the At a glance not to be impacted regardless of the grid size.

Screenshot_20240226-135638

Steps to reproduce

Steps to reproduce the behavior:

  1. Install and configure Smartspacer.

  2. In the Home screen option change the layout grid to 5x5

  3. In the Lawnchair experimental features enable "At a glance provider selection"

  4. Go to At a glance and enable "Show on Home Screen”

  5. Below that click the option and change the provider to Smartspacer.

  6. Check the At a glance content.

  7. Go back to Lawnchair home screen option and change layout grid to 5x6.

  8. Come back to the home screen and verify the Smartspacer contents.

Expected behavior

Irrespective of changing the home screen grid size, the Smartspacer At a glance contents on the sides should not be cropped. It doesn't crop contents for default Lawnchair At a glance.

Device information

  • Device: Google Pixel 7 Pro
  • OS: stock ROM Android version 14.0
  • App version: 14 Dev 314

Additional context

No response

sarojpanda44 avatar Feb 26 '24 13:02 sarojpanda44

The at a glance should really be separate from the grid setting. If you set the grid setting too high the at a glance is TINY lol.

st0neh avatar Feb 26 '24 20:02 st0neh

Not fixed in Lawnchair 14 Beta 1.

fg817sw751478 avatar Apr 03 '24 11:04 fg817sw751478

This became way worse in Lawnchair 14 beta 2 Screenshot_20240403-172245.png

(Beta 1 screenshot for example:) Screenshot_20240403-163008_Lawnchair.png

NiXTheDev avatar Apr 03 '24 14:04 NiXTheDev

Latest Smartspacer update does not help.

everypizza1 avatar Apr 07 '24 12:04 everypizza1

Latest Smartspacer update does not help.

It's most likely related to Lawnchair's padding, not Smartspacer. Lawnchair 12 has it all fine.

fg817sw751478 avatar Apr 07 '24 18:04 fg817sw751478

Fixed on grids up to 6x7 on debug version #729 6x8 grid still cropped off screen

slogar25 avatar Apr 10 '24 19:04 slogar25

Not sure which phone you are using. But it's not working for me on my Pixel 7 Pro on Dev #729. Screenshot_20240411-094156

sarojpanda44 avatar Apr 11 '24 06:04 sarojpanda44

Not sure which phone you are using. But it's not working for me on my Pixel 7 Pro on Dev #729. Screenshot_20240411-094156

Im on Pixel 8 Pro. Working on 6x7 grid Screenshot_20240411-100817

slogar25 avatar Apr 11 '24 14:04 slogar25

I was playing around with more settings and did some restarts. Somehow is fixed note for me. Guess is fixed. Just need a fresh configuration. Screenshot_20240413-201007

sarojpanda44 avatar Apr 13 '24 18:04 sarojpanda44

So now I know. I reduced the Dock Bottom padding from 100 to 80 and it fixed the Smartspacer padding issue. It is working for you because you are not using Dock

sarojpanda44 avatar Apr 13 '24 18:04 sarojpanda44

Not sure which phone you are using. But it's not working for me on my Pixel 7 Pro on Dev #729. Screenshot_20240411-094156

(Offtopic) What app you used for pixel clock font widget?

ujwal246 avatar Apr 23 '24 19:04 ujwal246

It's kwgt widget. Write me on Telegram @sarojpanda44 for the kwgt export.

sarojpanda44 avatar Apr 23 '24 21:04 sarojpanda44

3x3 grid Unihertz jelly (star) Screenshot_20240428-135851 Screenshot_20240428-140105 Only happens to the smartspacer one. Does get fixed when changing minimum width to 360 instead of 320, but then the rest of the phone becomes unusable.

MrDodojo avatar Apr 28 '24 14:04 MrDodojo

Only 5x6 grid works on my device..。

CoelacanthusHex avatar May 13 '24 17:05 CoelacanthusHex

@SuperDragonXD, this issue is still present. Screenshot_20240819-150000~2

MrDodojo avatar Aug 20 '24 07:08 MrDodojo

Are you using the Nightly versions?

SuperDragonXD avatar Aug 20 '24 08:08 SuperDragonXD

Called lawn chair (debug) right? I got the one from releases with the commits from 2 days ago. I do have A very small screen(unihertz jelly)

On Tue, Aug 20, 2024, 10:02 SuperDragonXD @.***> wrote:

Are you using the Nightly versions?

— Reply to this email directly, view it on GitHub https://github.com/LawnchairLauncher/lawnchair/issues/4096#issuecomment-2298222352, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMAIMGJI74NZHDNULZQ6Y3ZSLZY7AVCNFSM6AAAAABD2F7L6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGIZDEMZVGI . You are receiving this because you commented.Message ID: @.***>

MrDodojo avatar Aug 20 '24 08:08 MrDodojo

Could you try testing the latest nightly release to see if it fixes the issue?

SuperDragonXD avatar Aug 20 '24 11:08 SuperDragonXD

Still an issue

On Tue, Aug 20, 2024, 13:09 SuperDragonXD @.***> wrote:

Could you try testing the latest nightly release to see if it fixes the issue?

— Reply to this email directly, view it on GitHub https://github.com/LawnchairLauncher/lawnchair/issues/4096#issuecomment-2298593081, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMAIMG7IG2KJBB3ENOKHIDZSMPVVAVCNFSM6AAAAABD2F7L6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGU4TGMBYGE . You are receiving this because you commented.Message ID: @.***>

MrDodojo avatar Aug 20 '24 13:08 MrDodojo