lawnchair icon indicating copy to clipboard operation
lawnchair copied to clipboard

Published 20 hours ago • verified publisher icon LawnchairLauncher

link various calendars to calendar icons

Open daywalk3r666 opened this issue 2 years ago • 4 comments

Description

Link simple calendar/pro , acalendar/+ , aosp calendar and etar to themed calendar 8cin

Type of change

✅ : General change (non-breaking change that doesn't fit the below categories like copyediting) :x: Bug fix (non-breaking change which fixes an issue) :x: New feature (non-breaking change which adds functionality) :x: Breaking change (fix or feature that would cause existing functionality to not work as expected)

daywalk3r666 avatar Sep 18 '22 06:09 daywalk3r666

It seema this isn't working. Only google calendar and clock get themed

daywalk3r666 avatar Sep 18 '22 08:09 daywalk3r666

wouldn't it be better to do this in lawnicons?

ABAAN-WEBDESIGNGEEK avatar Sep 19 '22 10:09 ABAAN-WEBDESIGNGEEK

Nope. Lawnchair handles the dynamic icons, not Lawnicons. Lawnicons provides the static icons though

Also re "this isn't working", the clock/calendar values are hardcoded. I'll make a patch soon allowing dynamic icons to other clock/calendar apps.

SuperDragonXD avatar Sep 19 '22 10:09 SuperDragonXD

Ok thanks for info

daywalk3r666 avatar Sep 19 '22 10:09 daywalk3r666

@SuperDragonXD Did you started any work on clock/cal icon to othe oeam apps? Should I work on it if not started already?

naveenccmsd avatar Oct 12 '22 20:10 naveenccmsd

@SuperDragonXD Did you started any work on clock/cal icon to othe oeam apps? Should I work on it if not started already?

I actually haven't worked on it yet. If you want, you can work on it; it'll be appreciated.

SuperDragonXD avatar Oct 14 '22 10:10 SuperDragonXD

@SuperDragonXD , I applied patch to use same dynamic icons from google cal to other oem ,it was working. but later found that we are taking drawables from actual app insted of taking from lawnchair ie google clock itself , so It's not working if we uninstall google clock/cal app.

I tried to reuse same code but somewhere it's broking, Should I goahed create separate override methods insted of existing one??

naveenccmsd avatar Oct 16 '22 08:10 naveenccmsd

You could create separate override methods if modifying the existing method does not work. Also you can incorporate your changes in a Draft PR, so that other people can see your changes and also tell you what to change in your code for it to work.

SuperDragonXD avatar Oct 16 '22 10:10 SuperDragonXD

With this PR https://github.com/LawnchairLauncher/lawnchair/pull/3038 Is my PR still needed?

daywalk3r666 avatar Oct 17 '22 04:10 daywalk3r666

Nope, I already added your calendar , so please close this pr

naveenccmsd avatar Oct 17 '22 04:10 naveenccmsd

Yeah, I think it's safe to close the PR. Also @naveenccmsd you can add the author of this PR as a co-author of your current PR.

SuperDragonXD avatar Oct 17 '22 04:10 SuperDragonXD