Lavissa

Results 35 comments of Lavissa

@SchrodingersGat I'm not able to fix the conflicts until next week, but please let me know if I need to change anything else. Looking at the requested changes, I'm going...

@SchrodingersGat I agree that it's reasonable ho have it on bleeding-edge for a bit before commiting to a release. Any new settings are set to false by default, so there...

@SchrodingersGat Playwright tests seem to change status from run to run, and it's getting to become quite frustrating... The new tests pass locally, and they passed the QC check on...

Note: It's impossible with our current playwright config to run "global setting"-altering tests. Even with `test.describe.configure({ mode: 'serial' })`, Chromium and Firefox tests will run in parallell. In my ridiculous...

@SchrodingersGat I'm just gonna be blunt: The tests you want require me to write tests that do this: ``` while(setting_not_set(setting)) { sleep(1000) try_to_set_setting(setting) } await check_some_thing_depending_on_the_setting_hoping_that_the_setting_wasnt_changed_by_the_other_browser() ``` Unless I'm missing...

``` Running 8 tests using 2 workers 1 [Chromium] PUI - Pages - Purchasing - Pending transitions 2 [Firefox] PUI - Pages - Purchasing - Pending transitions ``` So it's...

@SchrodingersGat That would exclude the setting-based states. One suggestion I see thrown around online is to split the Playwright testing into two steps where you run non-destructive tests in parallell,...

@SchrodingersGat Aight, here we go. PUI tests are working. I've done a few things: 1. I've made a new directory `src/frontend/tests/destructive`. 2. The default `playwright.config.ts` file now ignores the above...

With working tests, I'm considering this ready for a final review

@SchrodingersGat Never heard back from you here. Seems like some parts need a rewrite now tho.