Laurenz Stampfl
Laurenz Stampfl
I think this can be closed.
No worries, I can do the tests! Might need a bit help with figuring out how to properly deal with paint servers, but I'll have a look at it myself...
> For marker tests, let's use triangle and not a line for the base shape. This way we would be able to test marker-mid as well. And let's remove opacity...
I looked a bit more into the source code, and I just had two (somewhat) related questions: 1. Is there a reason why we need to keep the `transform` attribute...
> Probably not. usvg was rewritten a billion times. Probably just a left-over. Let's leave to a separate patch. Okay, I'll open a separate PR for this! > In short...
So after doing some more digging into the source code, I'm honestly a bit clueless about how to implement support for properly resolved gradients/patterns without introducing too much "ugly" code....
No worries, I'll also give it some more thought!
So I think implementing proper support for gradients/patterns will be really tricky and probably require some bigger changes. Would it be okay for you if we merge this now (so...
> I would be able to work on it maybe next month. I don't want to merge a half-backed solution. It's not very resvg-like. I totally understand, let's leave it...
Added some more test cases which should cover the most tricky parts when implementing this for gradients and patterns. In case anyone feels adventurous enough to actually try this...