tch-rs icon indicating copy to clipboard operation
tch-rs copied to clipboard

What's the timeline to support pytorch 2.0?

Open freemanliu opened this issue 2 years ago • 3 comments

Pytorch 2.0 seems promising. https://pytorch.org/get-started/pytorch-2.0 And it is available in nightly. I wonder when will it be accessible through tch-rs. One thing is that the source codes probably need to be changed to add the counterpart of torch.compile.

Keep rolling, tch-rs!

freemanliu avatar Feb 02 '23 23:02 freemanliu

I don't have a very good understanding of what PyTorch 2.0 will mean for the C++ api but my current understanding is that the new compile api involves triton which is tightly knit to python, see e.g. this thread. Because of this, it may well be the case that tch ends up supporting PyTorch 2.0 but without having access to the new torch.compile (which would be sad as it's the most exciting part). Any pointer on this would be very welcom.

LaurentMazare avatar Feb 05 '23 20:02 LaurentMazare

Maybe consult Facebook? The gain is just too big to miss.

On Mon, 6 Feb 2023, 07:49 Laurent Mazare, @.***> wrote:

I don't have a very good understanding of what PyTorch 2.0 will mean for the C++ api but my current understanding is that the new compile api involves triton which is tightly knit to python, see e.g. this thread https://discuss.pytorch.org/t/pytorch-2-and-the-c-interface/168034/6. Because of this, it may well be the case that tch ends up supporting PyTorch 2.0 but without having access to the new torch.compile (which would be sad as it's the most exciting part). Any pointer on this would be very welcom.

— Reply to this email directly, view it on GitHub https://github.com/LaurentMazare/tch-rs/issues/619#issuecomment-1418260974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJKX36CBZXDYQMTGX52Q3ODWWAG4NANCNFSM6AAAAAAUPUS5NE . You are receiving this because you authored the thread.Message ID: @.***>

freemanliu avatar Feb 05 '23 21:02 freemanliu

Maybe for future readers of this issue. The current tch-rs support PyTorch 2.0 C++ API since v0.11 https://github.com/LaurentMazare/tch-rs/blob/main/CHANGELOG.md#v0110---2023-03-20

This issue can be closed.

haixuanTao avatar Jul 17 '23 11:07 haixuanTao