tch-rs icon indicating copy to clipboard operation
tch-rs copied to clipboard

Published 20 hours ago • verified publisher icon LaurentMazare

WIP: Build script fixed: includes separated from symbols.

Open npatsakula opened this issue 3 years ago • 1 comments

Hello! I found little bug in build.rs and would like to help :D

Problem

NixOS distributive (and some more) separating libtorch shared symbols and headers. And it would be great if we add ability to separate ENV variables for them.

Solution

  • [x] Add ENV variable (keep reverse compatibility).
  • [ ] Add documentation.
  • [ ] Make extra test.

npatsakula avatar Jul 28 '22 20:07 npatsakula

@LaurentMazare, hello! Can i ask for review?

npatsakula avatar Aug 22 '22 13:08 npatsakula

Looks reasonable, could you rebase this branch? Hopefully this should get rid of the clippy error in the CI.

LaurentMazare avatar Sep 10 '22 11:09 LaurentMazare

Looks reasonable, could you rebase this branch? Hopefully this should get rid of the clippy error in the CI.

Hello @LaurentMazare! I rebased my branch on new main, added small documentation paragraph into README.md and performed small improvements in build.rs code.

Now I think this MR is ready to merge.

npatsakula avatar Sep 12 '22 10:09 npatsakula

Merged, thanks for the PR.

LaurentMazare avatar Oct 09 '22 08:10 LaurentMazare