tch-rs icon indicating copy to clipboard operation
tch-rs copied to clipboard

Add more function from torch::cuda

Open vcarpani opened this issue 3 years ago • 3 comments

This PR adds some more torch::cuda functions and improves documentation for the existing ones.

vcarpani avatar Jun 22 '22 13:06 vcarpani

Hello, any updates on this?

In addition to that, my company is really interested in supporting this project since we are using it in production, can we help in any way with the maintenance of this repo?

vcarpani avatar Oct 10 '22 12:10 vcarpani

Sorry for the delay, I've added some comments. It's great to know that this is used in production, it would probably be helpful to know a bit more on how it's used / if there are some repos based on it so as to involve you e.g. when potentially introducing breaking changes.

LaurentMazare avatar Oct 10 '22 20:10 LaurentMazare

Sorry for the delay, I've added some comments. It's great to know that this is used in production, it would probably be helpful to know a bit more on how it's used / if there are some repos based on it so as to involve you e.g. when potentially introducing breaking changes.

No problems about the delay, thanks for maintaining this repo. We are currently using it in 2 different repos, one using the JIT loader and the other one using torch operators directly.

For breaking changes, I would propose to use a CHANGELOG file, if you believe it is a good idea, I can open a PR on the CHANGELOG format, so that all the people using the repo would have an idea of what changed and which version to be used in their production environments

vcarpani avatar Oct 10 '22 21:10 vcarpani

Should be solved now ;)

vcarpani avatar Dec 01 '22 18:12 vcarpani

Merged, thanks for the PR!

LaurentMazare avatar Dec 01 '22 22:12 LaurentMazare