Laurent AJDNIK

Results 11 comments of Laurent AJDNIK

BTW, shouldn't we add https://pypi.org/project/flake8-docstrings/ to CI ? I tested it locally and the results were... kinda wild...

> Note the last sentence of that link you sent me: > > > You should not document exceptions that get raised if the API specified in the docstring is...

> > BTW, shouldn't we add https://pypi.org/project/flake8-docstrings/ to CI ? > > I tested it locally and the results were... kinda wild... > > This is a great idea, though...

Hi @HGSilveri, here are some more thoughts about it. # TL;DR * 92 errors raised in the `develop` branch * 8 different error types, but mostly `TypeError` and `ValueError` *...

> One other thing: I believe that sometimes the built-in errors are abused, mostly out of laziness to not wanting to create a new error class. I would be in...

Back to the original issue of consistency for error messages. We could rewrite some of them already. Here are a few rules for `ValueError` when applied to a threshold: *...

> My only concern is the size of the error factory call becoming larger than the written message itself, and perhaps it being hard to decipher for someone reading the...

Hi @troelsfr and thanks for your feedback! First, I have to admit that, despite looking into it for a while, I am not too familiar yet with the whole architecture...

Thanks again @troelsfr for this very detailed reply! It helps me A LOT in better understanding the goals and ambitions of QAT. This is probably what we missed the most...

> A small update to this proposal: Passes are getting separated into separate folders which is the preliminary work to have them as stand-alone/opt compatible entities in PR #137 ....