GodotSteam_CSharpBindings icon indicating copy to clipboard operation
GodotSteam_CSharpBindings copied to clipboard

Type/Class cleanup: Steam.Input.cs

Open LauraWebdev opened this issue 2 years ago • 1 comments

LauraWebdev avatar Nov 10 '23 04:11 LauraWebdev

Multiple functions in Steam.Input.cs request handles in the form of signed long values. In all cases, the correct type to send is an unsigned long.

In addition, the "flags" arguments, such as in GetGlyphSVGForActionOrigin, should be corresponding enums with the [Flags] property. (For GetGlyphSVGForActionOrigin and GetGlyphPNGForActionOrigin, for example, the GDScript enum is Steam.InputGlyphStyle. Note that GDScript enums don't work properly as bitflags, so combining them in GDScript will cause warnings to appear. For these bindings, it's probably best to request arguments as flags, and then cast back to ulong for the call to GDScript.)

Formedras avatar Feb 29 '24 21:02 Formedras