manydecks icon indicating copy to clipboard operation
manydecks copied to clipboard

"Uncaught TypeError: Undefined has no properties"/ Loading loop for list of decks

Open elevenga opened this issue 1 year ago • 1 comments

When I'm going onto the Many Decks page no elements show up besides sign in button. Switching pages takes at least few minutes and an error loop occurs. It only happened while using Dark Reader extension. image

Steps to reproduce the behaviour (Tried only on firefox):

  1. Install Dark Reader extension
  2. Go to the decks page with the Dark Reader toggled on
  3. that's it

Quick fix that can be done by users: Adding page to the Dark Reader exceptions image

elevenga avatar Jul 11 '24 16:07 elevenga

Unfortunately injecting elements into the page as that extension does breaks Elm, which expects the DOM to be unchanged. When it is changed externally like that, those assumptions break and the result is as you see.

Fixing this would require a rewrite in something other than Elm, so I'm afraid this is not something that'll be fixed, stopping the extension mangling the page is the correct solution. An extension that only changes the styles of the site and not the DOM should work without any problems, and be able to do theme changing.

A native dark mode for the site is definitely on the to-do list, and the extremely slow loading is 100% an issue and the site desperately needs an update to fix it, but unfortunately I haven't had a chance to do so. I am aiming to, but no timeframe on when.

Lattyware avatar Jul 11 '24 17:07 Lattyware