SIMULATeQCD icon indicating copy to clipboard operation
SIMULATeQCD copied to clipboard

update all main files with the same runtime_error exception handling

Open luhuhis opened this issue 3 years ago • 6 comments

resolves #24

luhuhis avatar Feb 01 '22 17:02 luhuhis

Everything passes with CUDA 11.6 in this branch except the following:

  • DslashMulti
  • HBOR_multiple
  • hisqForce
  • hisqForceImagMu
  • rhmcTest
  • rhmcTest_4pf The first three are fixed in a0e0a5ff7f38d3907e7db2abb96aa7dd93568fe0, d5758b447bcb7b5c21f173d7b55f45bbb3ec365c, and d278c36edfc9ec5c429ef4fd162577aeb0c0597a, respectively. The last three presumably suffer from the same issue that hisqForce did with the introduction of CUDA 11.6?

clarkedavida avatar Feb 06 '22 23:02 clarkedavida

The issues with cuda 11.6 are unrelated to the changes introduced in this pr. I think we should be able to merge if everything passes on 11.0?

dbollweg avatar Feb 09 '22 06:02 dbollweg

I tend to agree with you, Dennis. Could either you or Lukas do the 11.0 tests and then merge it in if everything is fine?

clarkedavida avatar Feb 09 '22 10:02 clarkedavida

I agree, I will run the tests

lukas-mazur avatar Feb 09 '22 11:02 lukas-mazur

All tests (except the above mentioned tests) pass on single GPU. However, since try-catch adds some overhead, it would be good if timing tests could be done, before we merge this branch. Just to be sure.

lukas-mazur avatar Feb 14 '22 11:02 lukas-mazur

I think someone already tested this some time ago (maybe @dbollweg ?), but I agree. Although I would be surprised if it there is was any difference.

luhuhis avatar Feb 14 '22 15:02 luhuhis