SIMULATeQCD icon indicating copy to clipboard operation
SIMULATeQCD copied to clipboard

Check implicit type conversions in make_rng_state

Open luhuhis opened this issue 3 years ago • 0 comments

Do we have to worry about the implicit type conversion from long int to unsigned int in this function? lrand48 returns long ints, the aux_* variables are initialized as int, but later they are put into uint4 structs. Is this intended or just a small oversight?

https://github.com/LatticeQCD/SIMULATeQCD/blob/c5914ed4e6e71272cfbf825dc3f4715f35112c16/src/base/math/grnd.cpp#L90-L102

luhuhis avatar Aug 23 '22 10:08 luhuhis