Aleksei Lebedev

Results 89 comments of Aleksei Lebedev

After PR #996, I've realized that ~it will never be merged~ I need something more: 1) Removing unused types from the schema (probably related to #964) - we have a...

@spawnia could you please take a look on https://github.com/LastDragon-ru/lara-asp/blob/5c20332d05223a8611c3cb0e5e9647d693b02453/packages/graphql/src/SchemaPrinter/Misc/DirectiveResolver.php#L61-L103 ? Maybe I've missed something and there is a better/propper way to include type definitions from `Directive:definition()` into the schema.

> So I've created a new SchemaPrinter 😁 The [`SchemaPrinter` with few PHPUnit assertions](https://github.com/LastDragon-ru/lara-asp/tree/master/packages/graphql#schemaprinter--testing-assertions) for Schema/Types comparison are finally available as a part of `lara-asp` package (Lighthouse is required). So...

@spawnia not message (it is ok), just some way to get variables from `GraphQL\Error\Error`, eg `$error->getSource()->variables`.

+1 this is will be very useful for big angular apps (https://github.com/angular/angular-cli/issues/13734)

@g105b, thank you. I test my packages on windows just for the case. So this bug absolutely not critical :)

I've found that cache should be disabled while the AST Manipulation phase (because directives/args can change), so the first post updated.

I've also found that `ValidatorDirective` doesn't not call `Validator::setArgs()` after `ValidatorDirective::setArgumentValue()` call that is critical when directives cached. The first post updated.

> This change has the potential for a subtle breakage, exactly due to directives such as ValidatorDirective Yep. Also, a bit related issue: `BaseDirective::hydrate()` doesn't reset cached args. > I...