lw.comm-server icon indicating copy to clipboard operation
lw.comm-server copied to clipboard

Docker use node 16 and udev, generic debian base.

Open easytarget opened this issue 3 years ago • 5 comments
trafficstars

This updates the Dockerfile to support recent serialport changes and improve cross-platform support.

Changed the base image to the 'official' node16/bullseye image; this brings support for multiple platforms (armhf, arm64, i32, x64, ppc), and better supports node serialport + udev.

Added a DOCKER.md document to the repo detailing how to build+run with the correct nice setting.

easytarget avatar Apr 06 '22 11:04 easytarget

@easytarget Do you want me to merge this PR? You should be able to merge it yourself.

cprezzi avatar Apr 06 '22 11:04 cprezzi

@cprezzi It's not urgent, and I did want your feedback since I dont want to break anything that may rely on the docker build. I'm a bit concerned about if it is being used in the electron build.

Also; I dont seem to be able to merge this; not sure what is up there but I see 'Only those with write access to this repository can merge pull requests.` above; so I assume something went wrong there..

easytarget avatar Apr 06 '22 12:04 easytarget

I saw that you never acepted my invitation to the LaserWeb devteam. Now I re-invited you to the LaserWeb devteam and core-devs. You need to accept the invitation ;)

cprezzi avatar Apr 06 '22 15:04 cprezzi

Ok, I've got it now. I obviously missed the mail first time around. Thanks!

easytarget avatar Apr 06 '22 19:04 easytarget

@easytarget Do you want to finaly merge this PR? The docker file is not used for the electron build.

cprezzi avatar Nov 15 '23 08:11 cprezzi